Skip to content

Feature/t3iux03/update angular #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
freesbi wants to merge 41 commits into
base: master
Choose a base branch
from
Open

Feature/t3iux03/update angular #243

freesbi wants to merge 41 commits into from

Conversation

@freesbi
Copy link
Collaborator

@freesbi freesbi commented Jan 12, 2026

Description

Update Angular version to v21. Updated several components and tests

Which Component is affected or generated?

  • data-table
  • flowbar
  • quick-list
  • quick-list-compact
  • reactive-form-quick-list
  • reactive-form-quick-list-compact
  • readonly-form-field-wrapper
  • stepper
  • step
  • alert
  • card
  • file-upload
  • action-button
  • sidebar-layout
  • toolbar

Affected components was changed mainly to a new control flow appliance and structural directives usage removal (NgIf, NgFor). But also several changes applied to remove private API variables usage

@freesbi freesbi force-pushed the feature/t3iux03/update_angular branch from 0806c73 to 54cc3d9 Compare January 12, 2026 18:00
@poixpem poixpem self-requested a review January 19, 2026 07:22
@poixpem
Copy link
Collaborator

poixpem commented Jan 19, 2026

Library peer dependencies not updated - projects/material-addons/package.json still shows >= 16.0.0 for Angular packages instead of >= 21.0.0

@poixpem
Copy link
Collaborator

poixpem commented Jan 19, 2026

As we have already the branch for the "old" version we must make sure we have really all latest master fixes on that version-branch, too (I have not checked that, yet)

poixpem
poixpem requested changes Jan 19, 2026
View reviewed changes
Copy link
Collaborator

@poixpem poixpem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incomplete migration - data-table.component.html still has multiple legacy *ngIf/*ngFor/*ngSwitch directives that weren't migrated to the new @if/@for/@switch syntax

@freesbi freesbi force-pushed the feature/t3iux03/update_angular branch from 343496e to 01e50f9 Compare January 19, 2026 10:29
@freesbi
Copy link
Collaborator Author

freesbi commented Jan 19, 2026

As we have already the branch for the "old" version we must make sure we have really all latest master fixes on that version-branch, too (I have not checked that, yet)

Rebased with all of the latest changes from master branch

@freesbi
Copy link
Collaborator Author

freesbi commented Jan 19, 2026

Incomplete migration - data-table.component.html still has multiple legacy *ngIf/*ngFor/*ngSwitch directives that weren't migrated to the new @if/@for/@switch syntax

Yes, you're right. Missed this somehow. But fixed it now

@freesbi
Copy link
Collaborator Author

freesbi commented Jan 19, 2026

P.S. Cypress tests updates will be provided in a different PR. To not make this PR huge (which is already like that :) )Thanks for understanding.

@freesbi freesbi requested a review from poixpem January 19, 2026 11:43
xkilpoi
xkilpoi reviewed Jan 19, 2026
View reviewed changes
@freesbi freesbi requested a review from xkilpoi January 19, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Laess3r Laess3r Awaiting requested review from Laess3r

@stefan-isakovic stefan-isakovic Awaiting requested review from stefan-isakovic

@poixpem poixpem Awaiting requested review from poixpem

@xkilpoi xkilpoi Awaiting requested review from xkilpoi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@freesbi @poixpem @xkilpoi